Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Oct 13, 2024

The primary changes are:

  • Make the rpc<R> function require the fn argument.
  • Avoid decoding and parsing the request body multiple times in rpc<R> when there's a RequestException
  • Instead of Element.div(), Element.p(), and similar, use the type factory constructors (DivElement()) for easier migration to package:web.
  • Use e.getAttribute('attribute-key') instead of e.attributes['attribute-key'] as it avoids creating an unnecessary map but also makes migration to package:web easier.
  • Avoid a few non-null checks and assertions with slight restructurings

@parlough parlough marked this pull request as ready for review October 13, 2024 19:37
@jonasfj jonasfj requested a review from isoos October 17, 2024 08:59
@isoos isoos merged commit d6346c7 into dart-lang:master Oct 17, 2024
32 checks passed
@parlough parlough deleted the misc/web-app-api-cleanup branch October 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants